-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split floor into floor_common, floor, floor_ffi to be able to use floor without flutter. #638
split floor into floor_common, floor, floor_ffi to be able to use floor without flutter. #638
Conversation
…or without flutter.
thanks for implementing this improvement! i'll align our ci setup to these changes and eventually, i'll report back with suggested improvements. |
Thanks for considering my MR! I've been successfully using my branch in a small project in which I wanted to write a dart only CLI to use on desktop. One small issue I see is the generated code depends on If you have any concerns, I'll be happy to update this MR. Or feel free to use my MR as you see fit in case you want to use it as a basis to do your own MR. Thanks! |
@vitusortner Could you please . merge this pull request |
# Conflicts: # example/pubspec.lock # floor/lib/src/sqflite_database_factory.dart
…ed in sqflite_database_factory.dart
# Conflicts: # floor/pubspec.lock
…atabase_factory.dart
This reverts commit cbeb603.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #638 +/- ##
===========================================
+ Coverage 91.51% 94.31% +2.79%
===========================================
Files 11 10 -1
Lines 224 211 -13
===========================================
- Hits 205 199 -6
+ Misses 19 12 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # floor/pubspec.yaml
…rt_without_flutter
I see this PR checks in the generated code now. We did not have this before and they were git ignored, but only under /floor. Now that all this lives under floor_common, the gitignore must be updated. @hendrikvdkaaden Can you remove the generated files from git and after that update the gitignore file? |
closes #637